RFR: 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy [v3]

[Ajit Ghaisas]

On Mon, 12 Sep 2022 15:33:29 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Modified the tree/table view internals to suppress the horizontal (a.k.a. breadth in VirtualFlow) scroll bar when a constrained resize mode is in effect.  This change complements fixes added in [JDK-8089009](https://bugs.openjdk.org/browse/JDK-8089009) without addressing other bugs found in https://bugs.openjdk.org/browse/JDK-8292810
>
> Andy Goryachev has updated the pull request incrementally with two additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'origin/8089280.suppress' into 8089280.suppress
>  - 8089280: review comments

In general, the fix looks good.
I have observed missing spaces at few places in this fix. I will approve once these are fixed.

modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableSkinUtils.java line 213:

> 211: 
> 212:     /** returns true if the column resize policy is constrained */
> 213:     public static boolean isConstrainedResizePolicy(Callback<? extends ResizeFeaturesBase,Boolean> x) {

Minor : Need a space after `,`

modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableViewSkinBase.java line 899:

> 897: 
> 898:     void updateSuppressBreadthBar() {
> 899:         Callback<ResizeFeaturesBase,Boolean> p = TableSkinUtils.columnResizePolicyProperty(this).get();

Minor : Need a space after `,`

modules/javafx.controls/src/test/java/test/javafx/scene/control/TableViewTest.java line 5953:

> 5951:         TableView<String> table = new TableView<>();
> 5952:         for (int i = 0; i < 10; i++) {
> 5953:             final TableColumn<String,String> c = new TableColumn<>("C" + i);

Minor : Need a space after `,`

modules/javafx.controls/src/test/java/test/javafx/scene/control/TreeTableViewTest.java line 7109:

> 7107:         TreeTableView<String> table = new TreeTableView<>();
> 7108:         for (int i = 0; i < 10; i++) {
> 7109:             TreeTableColumn<String,String> c = new TreeTableColumn<>("C" + i);

Minor : Need a space after `,`

-------------

PR: https://git.openjdk.org/jfx/pull/894