RFR: 8089280: horizontal scrollbar should never become visible in TableView with constrained resize policy [v3]
Andy Goryachev
angorya at openjdk.org
Fri Sep 16 16:09:55 UTC 2022
On Fri, 16 Sep 2022 09:40:52 GMT, Ajit Ghaisas <aghaisas at openjdk.org> wrote:
>> Andy Goryachev has updated the pull request incrementally with two additional commits since the last revision:
>>
>> - Merge remote-tracking branch 'origin/8089280.suppress' into 8089280.suppress
>> - 8089280: review comments
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableSkinUtils.java line 213:
>
>> 211:
>> 212: /** returns true if the column resize policy is constrained */
>> 213: public static boolean isConstrainedResizePolicy(Callback<? extends ResizeFeaturesBase,Boolean> x) {
>
> Minor : Need a space after `,`
will do.
I do not like inconsistency: everywhere else in this file there is no space after comma in type parameters, for example
```TableViewSkinBase<?,?,?,?,?>```
so, if one were to use a formatter, it will format to
```TableViewSkinBase<?, ?, ?, ?, ?>```
which will look weird.
-------------
PR: https://git.openjdk.org/jfx/pull/894
More information about the openjfx-dev
mailing list