RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]

Alexander Matveev almatvee at openjdk.org
Tue Sep 27 01:22:41 UTC 2022


> There was two problems:
>  - uri.getPath() was returning null for jar URI, since it is not a standard URI and thus we did not detect file type based on extension.
>  - Our signature detection for MP3 had a bug and did not detect MP3 correctly. See comments in code.
>  
> Fixed by adding function to extract file name from jar URI and also signature detection was fixed for MP3.

Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:

  8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/902/files
  - new: https://git.openjdk.org/jfx/pull/902/files/6ec8b2e7..9830b77e

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=902&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=902&range=00-01

  Stats: 4 lines in 2 files changed: 1 ins; 0 del; 3 mod
  Patch: https://git.openjdk.org/jfx/pull/902.diff
  Fetch: git fetch https://git.openjdk.org/jfx pull/902/head:pull/902

PR: https://git.openjdk.org/jfx/pull/902


More information about the openjfx-dev mailing list