RFR: 8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]

Andy Goryachev angorya at openjdk.org
Tue Sep 27 15:09:41 UTC 2022


On Tue, 27 Sep 2022 01:22:41 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> There was two problems:
>>  - uri.getPath() was returning null for jar URI, since it is not a standard URI and thus we did not detect file type based on extension.
>>  - Our signature detection for MP3 had a bug and did not detect MP3 correctly. See comments in code.
>>  
>> Fixed by adding function to extract file name from jar URI and also signature detection was fixed for MP3.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8293971: Loading new Media from resources can sometimes fail when loading from FXML [v2]

changes look good to me

-------------

Marked as reviewed by angorya (Author).

PR: https://git.openjdk.org/jfx/pull/902


More information about the openjfx-dev mailing list