RFR: 8303038: Glass gtk3 sends scroll events with delta(x, y) = 0 [v5]

Thiago Milczarek Sayao tsayao at openjdk.org
Sun Apr 2 20:10:32 UTC 2023


On Wed, 1 Mar 2023 22:40:53 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> Simple fix to get the scroll deltas from GDK_SCROLL_SMOOTH. If we ignore this scroll event type, deltas are sent to java with the value equal to zero.
>> 
>> Here's whats happening:
>> 
>> We include all event masks, so when using gtk3 (>= 3.4.0) it includes `GDK_SMOOTH_SCROLL_MASK` meaning we receive duplicated events, one with  `direction = GDK_SMOOTH_SCROLL_MASK` and other with "legacy" direction (UP/DOWN).
>> 
>> When receiving the event corresponding to `GDK_SMOOTH_SCROLL_MASK` we ignored it causing it to send deltas (x,y) = 0.
>> 
>> The fix now checks if `GDK_SMOOTH_SCROLL_MASK` is supported and uses it, also adding smooth scroll functionality.
>
> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Improve direction

Commenting to avoid being closed.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1044#issuecomment-1493428860


More information about the openjfx-dev mailing list