RFR: 8283063: Optimize Observable{List/Set/Map}Wrapper.retainAll/removeAll [v4]

Kevin Rushforth kcr at openjdk.org
Mon Apr 3 13:53:10 UTC 2023


On Sun, 2 Apr 2023 23:45:52 GMT, Michael Strauß <mstrauss at openjdk.org> wrote:

>> modules/javafx.base/src/test/java/test/com/sun/javafx/collections/ObservableListWrapperTest.java line 41:
>> 
>>> 39: 
>>> 40:     @Nested
>>> 41:     class RemoveAllTest {
>> 
>> Empty line after class declaration.
>> 
>> Same for other places.
>
> I see that all over the JavaFX codebase. Do we have any guidance for that?

We're inconsistent on this. Since this is a new class, I'd probably lean towards adding the blank line.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/751#discussion_r1155993184


More information about the openjfx-dev mailing list