RFR: JDK-8305248: TableView not rendered correctly after column is made visible if fixed cell size is set [v2]

Marius Hanl mhanl at openjdk.org
Mon Apr 3 09:48:06 UTC 2023


On Mon, 3 Apr 2023 08:10:04 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> Marius Hanl has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - JDK-8305248: Added the tests also for TreeTableRow
>>  - JDK-8305248: Improve comments
>
> modules/javafx.controls/src/test/java/test/javafx/scene/control/skin/TreeTableRowSkinTest.java line 260:
> 
>> 258:      */
>> 259:     @Test
>> 260:     public void testMakeInvisibleColumnVisible() {
> 
> These two tests also pass with/without your patch, but I guess we want to have them to prevent any future issue?

Yes. `TreeTableView` does a lot more layout passes then `TableView`. 
I had a look on this in the past and in general the table implementations do too much (re)layouting unfortunately, and that sometimes masks bugs, like this one.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1077#discussion_r1155730499


More information about the openjfx-dev mailing list