RFR: JDK-8305248: TableView not rendered correctly after column is made visible if fixed cell size is set [v2]

[Jose Pereda]

On Mon, 3 Apr 2023 09:31:15 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/TableRowSkinBase.java line 356:
>> 
>>> 354:                     getChildren().add(tableCell);
>>> 355:                 }
>>> 356:                 // Note: prefWidth() has to be called only after the tableCell is added to the tableRow, if it wasn't
>> 
>> Minor: there is no explicit rule about limiting line comments to 80 characters, as far as I know, but it might be good to apply it to your comments (also to the test ones)
>
> Actually there is! In https://github.com/openjdk/jfx/blob/master/CONTRIBUTING.md
>> Line width is no more than 120 character
> 
> That is what I also use here and actually did in other PRs as well.
> If there is another rule I can of course change it, but a max line width of 120 is a reasonable value I saw in a lot of other (Java) projects too.

Ok, right, I missed that.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1077#discussion_r1155737810