RFR: JDK-8305885: Use ReadOnly*PropertyBase class where possible [v2]

Nir Lisker nlisker at openjdk.org
Mon Apr 17 05:44:45 UTC 2023


On Sat, 15 Apr 2023 01:36:48 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> modules/javafx.graphics/src/main/java/com/sun/javafx/scene/TreeShowingExpression.java line 44:
>> 
>>> 42:  * an observable form.
>>> 43:  */
>>> 44: public class TreeShowingExpression extends ReadOnlyBooleanPropertyBase {
>> 
>> Maybe you could rename the class to `TreeShowingProperty`?
>
> Yeah, that would definitely be better.

In `Node` we have `TreeVisiblePropertyReadOnly`. Best to align it with the other properties and remove the "ReadOnly" part.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1092#discussion_r1168188290


More information about the openjfx-dev mailing list