RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v10]

[Martin Fox]

On Thu, 20 Apr 2023 23:49:40 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Martin Fox has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision:
>> 
>>  - Merge remote-tracking branch 'upstream/master' into macshortcut
>>  - Coding style consistency (mostly)
>>  - Added Spanish to KeyboardTest and fixed related bug. Changes based on review feedback.
>>  - Added manual cross-platform keyboard handling test
>>  - Bug fixes in Robot. Ensure symbols uncovered using Option are ignored.
>>  - Merge branch 'master' into macshortcut
>>  - Fixed whitespace error.
>>  - A small number of keyboard layouts require the Option key to reach
>>    critical letters like 'Q'. Added a third probe (after Command and
>>    Shift+Command) to look for letters that require Option. The
>>    keyboards in question are Azeri, Turkmen, and the Sami layouts.
>>  - The code now queries both the shifted and unshifted characters for a key
>>    favoring digits and letters over everything else. This ensures we catch
>>    the digits on the French layout without interfering with Dvorak.
>>  - Mac - generate KeyCodes that match user's active keyboard layout.
>
> tests/manual/events/KeyboardTest.java line 26:
> 
>> 24:  */
>> 25: 
>> 26: import java.util.ArrayList;
> 
> would it make sense to avoid using the default package?
> also perhaps move the tests to ./src?

I was following the lead of the other manual tests which mostly use the default package and do not place their files under a src directory (media/FXMediaPlayer is the exception on both counts). With that said I'll do whatever is most convenient for testers.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/425#discussion_r1173205213