RFR: 8150709: Mac OSX and German Keyboard Layout (Y/Z) [v10]

Kevin Rushforth kcr at openjdk.org
Fri Apr 21 12:29:02 UTC 2023


On Fri, 21 Apr 2023 00:48:24 GMT, Martin Fox <duke at openjdk.org> wrote:

>> tests/manual/events/KeyboardTest.java line 26:
>> 
>>> 24:  */
>>> 25: 
>>> 26: import java.util.ArrayList;
>> 
>> would it make sense to avoid using the default package?
>> also perhaps move the tests to ./src?
>
> I was following the lead of the other manual tests which mostly use the default package and do not place their files under a src directory (media/FXMediaPlayer is the exception on both counts). With that said I'll do whatever is most convenient for testers.

Leaving it in the default package is best for now, given that this is in an existing directory with other test programs in the default package. We can file a follow-up RFE to move groups of manual tests to a named package.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/425#discussion_r1173707265


More information about the openjfx-dev mailing list