RFR: 8297316: [TestBug] LocalDateTimeStringConverterTest.testChronologyConsistency fails with JDK 20 [v2]

Ambarish Rapte arapte at openjdk.org
Tue Apr 25 15:36:37 UTC 2023


> The expected result was changed due to an enhancement in JDK: 
> [JDK-8284840](https://bugs.openjdk.org/browse/JDK-8284840): Update CLDR to Version 42.0
> Similar tests were corrected in JDK along with the enhancement: [check this for example](https://github.com/openjdk/jdk/blob/4900517479f12b59cd8f1c31ad94ad7487c522f7/test/jdk/java/time/test/java/time/format/TestUnicodeExtension.java#L130)
> 
> We need to make similar change. But the expected result is different before JDK20 and with JDK20. The fix checks JDK major version to change expected result accordingly.

Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:

  address review comment

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1114/files
  - new: https://git.openjdk.org/jfx/pull/1114/files/e7a5cf97..4c6be671

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1114&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1114&range=00-01

  Stats: 18 lines in 1 file changed: 9 ins; 9 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/1114.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1114/head:pull/1114

PR: https://git.openjdk.org/jfx/pull/1114


More information about the openjfx-dev mailing list