RFR: 8297316: [TestBug] LocalDateTimeStringConverterTest.testChronologyConsistency fails with JDK 20 [v2]

Tue Apr 25 17:06:23 UTC 2023

On Tue, 25 Apr 2023 12:23:25 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Ambarish Rapte has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   address review comment
>
> modules/javafx.base/src/test/java/test/javafx/util/converter/LocalDateTimeStringConverterTest.java line 115:
> 
>> 113:         } else {
>> 114:             JAPANESE_DATE_STRING = "Saturday, January 12, 60 Shōwa, 12:34:56\u202fPM";
>> 115:         }
> 
> Minor: I think this could move to the (static) `@BeforeClass` method rather than being recomputed for each instance.

It is now moved to the `@BeforeClass` method.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1114#discussion_r1176801985