RFR: JDK-8312058: Documentation improvements for subscription based listeners [v4]

John Hendrikx jhendrikx at openjdk.org
Fri Aug 11 15:42:29 UTC 2023


On Fri, 11 Aug 2023 14:20:43 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update Subscription documentation wording and add example
>
> modules/javafx.base/src/main/java/javafx/util/Subscription.java line 33:
> 
>> 31: /**
>> 32:  * Represents a cancel or cleanup operation for an action be cancelled or
>> 33:  * allocated resources. Subscriptions can be obtained, for example, as a result
> 
> Somethign is missing in the sentence, should it be "...for an action that can be cancelled or that allocates resources"

Sorry, missed that somehow, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1177#discussion_r1291488429


More information about the openjfx-dev mailing list