RFR: JDK-8187314: All Cells: must show backing data always

[Andy Goryachev]

On Fri, 4 Aug 2023 18:13:34 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

> Before, the `updateItem` method was called with the new value that was committed via `commitEdit()`.
> This is problematic as developers may setup a commit handler via `setOnEditCommit`, which may reject the edit (or change the value otherwise).
> We therefore do call the `updateItem(-1)` which will also call `updateItem` but with the real underlying value.
> 
> Changed and added tests for all 4 cells.

modules/javafx.controls/src/test/java/test/javafx/scene/control/ListCellTest.java line 1113:

> 1111:      */
> 1112:     @Test
> 1113:     public void testEditCommitValueChangeIsReflectedInCell() {

this test passes with the fix, fails without as expected.
but for some reason I cannot reproduce the issue with ListView in the MonkeyTester
https://github.com/andy-goryachev-oracle/MonkeyTest

(List View Page -> select 'editable' -> double click to edit, type "updated" to save changes, any other text to reject)

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1197#discussion_r1295094922