RFR: 8313650: Add hasProperties method to MenuItem and Toggle

John Hendrikx jhendrikx at openjdk.org
Fri Aug 18 22:13:34 UTC 2023


On Fri, 18 Aug 2023 17:06:57 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> Adding new 
> `boolean hasProperties()`
>  method to MenuItem and Toggle only.
> 
> This change requires CSR.

modules/javafx.controls/src/main/java/javafx/scene/control/MenuItem.java line 532:

> 530:     /**
> 531:      * Tests if MenuItem has properties.
> 532:      * @return true if node has properties.

Suggestion:

     * Tests if the menu item has properties.
     * @return {@code true} if the menu item has properties

Or can use `{@code MenuItem}`

modules/javafx.controls/src/main/java/javafx/scene/control/Toggle.java line 111:

> 109:      * Tests if Toggle has properties.
> 110:      * @return true if node has properties.
> 111:      */

Suggestion:

    /**
     * Tests if this toggle has properties.
     *
     * @return {@code true} if this toggle has properties
     * @since 22
     */

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1215#discussion_r1298895197
PR Review Comment: https://git.openjdk.org/jfx/pull/1215#discussion_r1298895810


More information about the openjfx-dev mailing list