RFR: 8313650: Add hasProperties method to MenuItem and Toggle

Andy Goryachev angorya at openjdk.org
Fri Aug 18 22:28:31 UTC 2023


On Fri, 18 Aug 2023 22:08:35 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Adding new 
>> `boolean hasProperties()`
>>  method to MenuItem and Toggle only.
>> 
>> This change requires CSR.
>
> modules/javafx.controls/src/main/java/javafx/scene/control/MenuItem.java line 532:
> 
>> 530:     /**
>> 531:      * Tests if MenuItem has properties.
>> 532:      * @return true if node has properties.
> 
> Suggestion:
> 
>      * Tests if the menu item has properties.
>      * @return {@code true} if the menu item has properties
> 
> Or can use `{@code MenuItem}`

I like this, thanks.  I won't be fixing the javadoc in other places - it's not that critical.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1215#discussion_r1298901679


More information about the openjfx-dev mailing list