RFR: 8306083: Text.hitTest is incorrect when Text node is present in TextFlow [v6]

[Karthik P K]

On Mon, 21 Aug 2023 14:40:09 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review comments
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/text/PrismTextLayout.java line 782:
> 
>> 780:     }
>> 781: 
>> 782: 
> 
> is there an unnecessary newline here?

Yes. Removed unnecessary newline

> May be `Window w` would be better than `st`

Yes. It is much better. Updated the code.

 >Should it be (int) or (int)Math.round(...) (or (int)Math.rint(...) ?)

I think (int) is sufficient in this case.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1157#discussion_r1300482942
PR Review Comment: https://git.openjdk.org/jfx/pull/1157#discussion_r1300484016