RFR: 8313651: Add 'final' keyword to public property methods in controls [v4]

[John Hendrikx]

On Mon, 21 Aug 2023 23:11:49 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> In the Control hierarchy, all property accessor methods must be declared `final`.
>> 
>> Added a test to check for missing `final` keyword and added the said keyword where required.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Marked as reviewed by jhendrikx (Committer).

modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlPropertiesTest.java line 98:

> 96: public class ControlPropertiesTest {
> 97: 
> 98:     private static final boolean FAIL_FAST = !true;

Did you intend to commit this?  It was `true` before which seems good for tests, otherwise I'd really suggest using `false` here.

-------------

PR Review: https://git.openjdk.org/jfx/pull/1213#pullrequestreview-1588400997
PR Review Comment: https://git.openjdk.org/jfx/pull/1213#discussion_r1300989880