RFR: 8320359: ImageView: add styleable fitWidth, fitHeight, preserveRatio, smooth properties [v3]

[Andy Goryachev]

On Fri, 1 Dec 2023 17:34:05 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

>> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   save 8 bytes
>
> modules/javafx.graphics/src/main/docs/javafx/scene/doc-files/cssref.html line 1887:
> 
>> 1885:           <th class="propertyname" scope="row">-fx-fit-height</th>
>> 1886:           <td class="value"><a href="#typenumber" class="typelink"><number></a></td>
>> 1887:           <td>0</td>
> 
> Since you don't specify a style class for the newly added properties, they will all be left justified. The existing `null` value for `-fx-image` specifies `class="default"` which centers it. I recommend either adding the `class="default"` to all of the newly added properties, or removing it from the default value of the existing `fx-image` property.
> 
> I'll reapprove if you want to make the change.

thank you!  I am going to add class="default" as it allows for styling of the default column.

Two notes:
- There are a few other places where `class="default"` is omitted (HBox for instance).  We may want to fix it in a separate PR.
- I don't think the center alignment is the right choice here, I would rather see this column left aligned.  Perhaps we should fix the `.default` class as part of the enhancement.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1293#discussion_r1412455129