[External] : Re: eclipse warnings

[Kevin Rushforth]

Good point.

-- Kevin


On 12/4/2023 9:24 AM, Johan Vos wrote:
> Also, these commits often affect many files at once (in scattered 
> locations), and that makes backports harder.
>
> - Johan
>
> On Mon, Dec 4, 2023 at 6:14 PM Kevin Rushforth 
> <kevin.rushforth at oracle.com> wrote:
>
>     We did a few of these sort of cleanup fixes a year or so ago.
>
>     In general, this sort of cleanup *might* be useful, but also
>     causes some code churn and takes review cycles to ensure that
>     there is no unintentional side effect.
>
>     The last two might be OK cleanup tasks, but I wouldn't make them a
>     high priority. Worth noting is that a seemingly redundant null
>     check or instanceof check is not always a bad thing, so I wouldn't
>     clean up all of them.
>
>     The first group is the more interesting one. In some cases a
>     potential null access can highlight actual bugs. However, I oppose
>     any automated solution for these, since adding a null check where
>     you don't expect a null (even if you IDE thinks it might be
>     possible) can hide the root cause of a problem.
>
>     We aren't going to enforce these, though, so you'll likely need to
>     configure your IDE to be less picky.
>
>     -- Kevin
>
>
>     On 12/4/2023 8:34 AM, Andy Goryachev wrote:
>>
>>     Dear colleagues:
>>
>>     Imported the openjfx project into another workspace with a more
>>     stringent error checking and discovered a few issues:
>>
>>       * potential null pointer access: 295
>>       * unnecessary cast or instanceof: 190
>>       * redundant null check: 61
>>
>>     Do we want to clean these up?
>>
>>     -andy
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/openjfx-dev/attachments/20231204/9d180705/attachment.htm>