RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]

Thiago Milczarek Sayao tsayao at openjdk.org
Mon Dec 18 10:31:53 UTC 2023


On Mon, 18 Dec 2023 10:20:35 GMT, Jose Pereda <jpereda at openjdk.org> wrote:

>> I think the docs are wrong, I probably exists since 3.20, so maybe check for `GTK_CHECK_VERSION(3, 20, 0);`.
>> 
>> 
>> This is the compilation error on Ubuntu 16.04:
>> `/home/tsayao/jose/jfx/modules/javafx.graphics/src/main/native-glass/gtk/wrapped.c:200:34: error: unknown type name ‘GdkSeat’
>> `
>
> Okay, that is unfortunate (GTK docs inaccurate), but makes sense.
> 
> I'll add the compile-time checks to `wrapped.c`. But then, using `dlsym` seems redundant, as we can simply call the seat functions directly?

The check is to allow compilation and test on Ubuntu 16.04 - When shipping the final build it should be built on gtk 3.20+, so both dlsym and the check makes sense. 

So when running on Ubuntu 16.04:
- For testing on the platform, the #ifdef will make it possible to compile;
- For running the released built (which should be built on gtk 3.20+) dlsym will fail and fallback;

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1305#discussion_r1429875706


More information about the openjfx-dev mailing list