RFR: 8320965: Scrolling on a touch enabled display fails on Wayland [v2]
Thiago Milczarek Sayao
tsayao at openjdk.org
Mon Dec 18 10:38:52 UTC 2023
On Mon, 18 Dec 2023 10:29:00 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:
>> Okay, that is unfortunate (GTK docs inaccurate), but makes sense.
>>
>> I'll add the compile-time checks to `wrapped.c`. But then, using `dlsym` seems redundant, as we can simply call the seat functions directly?
>
> The check is to allow compilation and test on Ubuntu 16.04 - When shipping the final build it should be built on gtk 3.20+, so both dlsym and the check makes sense.
>
> So when running on Ubuntu 16.04:
> - For testing on the platform, the #ifdef will make it possible to compile;
> - For running the released built (which should be built on gtk 3.20+) dlsym will fail and fallback;
That's only if we want to keep building working on 16.04. I think it makes easier to test on it.
But, it's already failing for Platform preferences API code.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1305#discussion_r1429888067
More information about the openjfx-dev
mailing list