RFR: 8298382: JavaFX ChartArea Accessibility Reader [v4]

Andy Goryachev angorya at openjdk.org
Fri Feb 3 00:41:00 UTC 2023


On Thu, 2 Feb 2023 21:14:14 GMT, Alexander Zuev <kizune at openjdk.org> wrote:

>> Still, I would recommend adding a comment (since now is the time when we know all the context, and in the future we might forget or lose the context), may be something like
>> 
>> 
>> # {seriesName} {xAxisName} is {currentX} {yAxisName} is {currentY}
>> XYChart.series.accessibleText={0} {1} is {2} {3} is {4}
>
>> Still, I would recommend adding a comment (since now is the time when we know all the context, and in the future we might forget or lose the context), may be something like
> 
> Good idea, let me do it for both strings with parameters

sorry to hold up the review - I'll speak to Naoto Sato tomorrow (2/3/23 @ 11:00) regarding the requirements for translation hints, and either approve or let you know what they expect us to do.

-------------

PR: https://git.openjdk.org/jfx/pull/1016


More information about the openjfx-dev mailing list