RFR: 8173321: TableView: Click on right trough has no effect when cell height is higher than viewport height [v2]
Kevin Rushforth
kcr at openjdk.org
Mon Feb 6 13:40:59 UTC 2023
On Sun, 22 Jan 2023 15:19:48 GMT, JoachimSchriek <duke at openjdk.org> wrote:
>> JoachimSchriek has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Committed Test Case for [openjdk/jfx] 8173321: Click on trough has no
>> effect when cell height > viewport (PR #985):
>
> It was not feasible for me -at least as i saw it- to integrate the tests in the existing tests without using a robot because I think the behavior reported in the bug report mostly relates to the reaction of the UI to mouse clicks.
@JoachimSchriek In addition to restoring the mistakenly-deleted file, I noticed that you don't have GitHub actions enabled (else you would have discovered this problem right away). Also, your branch is fairly out of date with respect to the upstream master.
To that end, I recommend doing the following:
1. Merge the latest upstream master into your branch
2. Enable GitHub actions in your repo (follow the instructions listed above in the details of "Pre-submit test status Skipped — Testing is not configured" -- the short version is that you need to click the big green button in the "Actions" tab of your repo)
3. Restore VirtualFlow.java such that it is identical to the upstream master.
-------------
PR: https://git.openjdk.org/jfx/pull/985
More information about the openjfx-dev
mailing list