RFR: 8230833: LabeledSkinBase computes wrong height with ContentDisplay.GRAPHIC_ONLY [v3]

Karthik P K kpk at openjdk.org
Tue Feb 7 05:25:10 UTC 2023


On Mon, 6 Feb 2023 22:50:30 GMT, John Hendrikx <jhendrikx at openjdk.org> wrote:

>> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Code optimization
>
> modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java line 331:
> 
>> 329: 
>> 330:         double width;
>> 331:         if(isIgnoreGraphic()) {
> 
> minor: missed a space here after `if`

Updated code.

> modules/javafx.controls/src/main/java/javafx/scene/control/skin/LabeledSkinBase.java line 393:
> 
>> 391:             if (isIgnoreText()) {
>> 392:                 height = graphicHeight;
>> 393:             } else if (contentDisplay == TOP || contentDisplay == BOTTOM){
> 
> minor: missing space before `{`

Updated code.

-------------

PR: https://git.openjdk.org/jfx/pull/996


More information about the openjfx-dev mailing list