RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository

[Marius Hanl]

On Mon, 23 Jan 2023 23:55:51 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

> This PR does:
> 
> - Remove specific Idea files and let it be imported from gradle;
> - Adds checkstyle (to use with checkstyle plugin - it will let you know style mistakes);
> - Configures auto-format to sun style (with the changes mentioned in [Code Style Rules](https://wiki.openjdk.org/display/OpenJFX/Code+Style+Rules));
> - Automatically sets Copyright notice (updates year too);
> - Run configurations for samples/toys and builds.

Looks good to me. I just tested it with the newest `IntelliJ` version (2022.3.2) and it works fine.
It also follows what IntelliJ is suggesting. 
Also the gradle changes looks fine to me, although not sure how I can start the manual tests.
I left some comments.

.idea/codeStyles/Project.xml line 2:

> 1: <component name="ProjectCodeStyleConfiguration">
> 2:   <code_scheme name="Project" version="173">

We should consider adding `<option name="LINE_SEPARATOR" value="
" />` -> \n as separator

.idea/codeStyles/Project.xml line 2:

> 1: <component name="ProjectCodeStyleConfiguration">
> 2:   <code_scheme name="Project" version="173">

Maybe `OpenJFX` is a better name here?

.idea/misc.xml line 8:

> 6:   </component>
> 7:   <component name="IdProvider" IDEtalkID="9BC0DE4049720C1246C2D3B835C6F7C3" />
> 8:   <component name="ProjectRootManager" version="2" languageLevel="JDK_17" project-jdk-name="19" project-jdk-type="JavaSDK">

I think this should be `project-jdk-name="17"`. When I check out this PR, IntelliJ also changed that automatically.

.idea/runConfigurations/Ensemble8_jar.xml line 1:

> 1: <component name="ProjectRunConfigurationManager">

Do we really need these run configurations (except `Run_Robot_Tests.xml`, which is useful)

.idea/runConfigurations/Run_Robot_Tests.xml line 7:

> 5:       <option name="externalProjectPath" value="$PROJECT_DIR$" />
> 6:       <option name="externalSystemIdString" value="GRADLE" />
> 7:       <option name="scriptParameters" value="-PFULL_TEST=true -PUSE_ROBOT=true" />

Is this also possible for manual tests? Or how do you launch manual tests?

-------------

PR: https://git.openjdk.org/jfx/pull/1009