RFR: JDK-8223373: Remove IntelliJ IDEA specific files from the source code repository [v2]

[Thiago Milczarek Sayao]

On Mon, 13 Feb 2023 17:48:35 GMT, Marius Hanl <mhanl at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review changes
>
> .idea/codeStyles/Project.xml line 2:
> 
>> 1: <component name="ProjectCodeStyleConfiguration">
>> 2:   <code_scheme name="Project" version="173">
> 
> Maybe `OpenJFX` is a better name here?

I tried to change it but didn't work. It seems IntelliJ expects "Project" there.

> .idea/codeStyles/Project.xml line 2:
> 
>> 1: <component name="ProjectCodeStyleConfiguration">
>> 2:   <code_scheme name="Project" version="173">
> 
> We should consider adding `<option name="LINE_SEPARATOR" value="
" />` -> \n as separator

Added.

> .idea/misc.xml line 8:
> 
>> 6:   </component>
>> 7:   <component name="IdProvider" IDEtalkID="9BC0DE4049720C1246C2D3B835C6F7C3" />
>> 8:   <component name="ProjectRootManager" version="2" languageLevel="JDK_17" project-jdk-name="19" project-jdk-type="JavaSDK">
> 
> I think this should be `project-jdk-name="17"`. When I check out this PR, IntelliJ also changed that automatically.

Each user probably would have to configure a JDK for the project.

> .idea/runConfigurations/Ensemble8_jar.xml line 1:
> 
>> 1: <component name="ProjectRunConfigurationManager">
> 
> Do we really need these run configurations (except `Run_Robot_Tests.xml`, which is useful)

Yeah, I agree. Removed those and left the robot tests.

> .idea/runConfigurations/Run_Robot_Tests.xml line 7:
> 
>> 5:       <option name="externalProjectPath" value="$PROJECT_DIR$" />
>> 6:       <option name="externalSystemIdString" value="GRADLE" />
>> 7:       <option name="scriptParameters" value="-PFULL_TEST=true -PUSE_ROBOT=true" />
> 
> Is this also possible for manual tests? Or how do you launch manual tests?

I do it by clicking on the run icon of the main method. Manual tests uses non-standard folder structure, so I had to customize the gradle script. As they are not part of the build, it's not possible (I think) to create run configurations.

-------------

PR: https://git.openjdk.org/jfx/pull/1009