RFR: 8231864: JavaFX Labels in Tab's VBox is not displayed until it is clicked [v2]

Lukasz Kostyra lkostyra at openjdk.org
Mon Jan 2 14:10:20 UTC 2023


On Wed, 21 Dec 2022 13:38:31 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

>> Lukasz Kostyra has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   NGNode: Change comment at dirty bounds update for clarification
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/sg/prism/NGNode.java line 335:
> 
>> 333:         } else {
>> 334:             // TODO I think this is vestigial from Scenario and will never
>> 335:             // actually occur in real life... (RT-23956)
> 
> The comments should be removed and updated to explain the scenario when flow enters the else block and I think RT-23956 can be closed with this fix.

I updated the comment. I agree, RT-23956 can now be closed.

-------------

PR: https://git.openjdk.org/jfx/pull/978


More information about the openjfx-dev mailing list