RFR: 8159048: Null PulseReceiver in AbstractMasterTimer [v2]

Jose Pereda jpereda at openjdk.org
Mon Jul 31 17:47:06 UTC 2023


> This PR adds a check to the Animation and AnimationTimer public methods to verify that these are called from the JavaFX Application thread. If the call is done from any other thread, an IllegalStateException will be thrown.
> 
> This will prevent users from getting unexpected errors (typically NPE, like the one posted in the JBS issue), and will fail fast with a clear exception and reason for it.
> 
> The javadoc of the Animation and AnimationTimer classes and public methods has been updated accordingly.
> 
> Tests for both classes have been included, failing (as in no exceptions were thrown when calling from a background thread) before this patch, and passing (as in ISE was thrown).

Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:

  Removed extra lines

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/1167/files
  - new: https://git.openjdk.org/jfx/pull/1167/files/284c5a13..719817d7

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=1167&range=01
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=1167&range=00-01

  Stats: 2 lines in 2 files changed: 0 ins; 2 del; 0 mod
  Patch: https://git.openjdk.org/jfx/pull/1167.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/1167/head:pull/1167

PR: https://git.openjdk.org/jfx/pull/1167


More information about the openjfx-dev mailing list