RFR: 8159048: Null PulseReceiver in AbstractMasterTimer [v2]

Jose Pereda jpereda at openjdk.org
Mon Jul 31 17:47:08 UTC 2023


On Mon, 31 Jul 2023 17:12:41 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Jose Pereda has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed extra lines
>
> tests/system/src/test/java/test/com/sun/javafx/animation/AnimationTimerTest.java line 62:
> 
>> 60:             startupLatch.countDown();
>> 61:         }
>> 62: 
> 
> minor: extra newline?

removed

> tests/system/src/test/java/test/com/sun/javafx/animation/AnimationTimerTest.java line 82:
> 
>> 80:                 @Override public void handle(long l) {
>> 81:                     frameCounter.countDown();
>> 82:                     if (frameCounter.getCount() == 0L) {
> 
> thank you for 0L!

:)

> tests/system/src/test/java/test/com/sun/javafx/animation/AnimationTimerTest.java line 112:
> 
>> 110:         Platform.runLater(timer::start);
>> 111:     }
>> 112: 
> 
> minor: extra newline

removed

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1167#discussion_r1279670408
PR Review Comment: https://git.openjdk.org/jfx/pull/1167#discussion_r1279670299
PR Review Comment: https://git.openjdk.org/jfx/pull/1167#discussion_r1279670174


More information about the openjfx-dev mailing list