RFR: 8309470: Potential performance improvements in VirtualFlow

Marius Hanl mhanl at openjdk.org
Thu Jun 8 06:59:45 UTC 2023


On Thu, 8 Jun 2023 00:07:20 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> I don't see any ill effects in the MonkeyTester. There is still a bit of lag with 10,000,000 row model, same as before.

Yeah for me as well. This is a very minor improvement and actually with this PR the following assertion is now true:
When a fixed cell size is set, the `computeXXX` methods from the cell will never be called.
This is also what you would expect, as before the fixed cell size may be mixed with computed sizes in some circumstances.

If you e.g. subclass `TableRow` and do heavy computation inside the `computeXXX` methods, those will not be called.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1150#issuecomment-1581992580


More information about the openjfx-dev mailing list