RFR: 8309470: Potential performance improvements in VirtualFlow [v5]
Andy Goryachev
angorya at openjdk.org
Thu Jun 8 17:55:33 UTC 2023
On Thu, 8 Jun 2023 06:47:44 GMT, Marius Hanl <mhanl at openjdk.org> wrote:
>> modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 1954:
>>
>>> 1952: * Gets the breadth of a specific cell
>>> 1953: */
>>> 1954: double getCellBreadth(T cell) {
>>
>> is there a possibility of introducing runtime errors?
>
> No, this is just cosmetic and more correct as every cell inside the VirtualFlow is bound to the type parameter T.
this method should have been private.
I see no other callers outside of VirtualFlow, so it's probably safe.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1150#discussion_r1223375875
More information about the openjfx-dev
mailing list