RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v3]

[Martin Fox]

On Tue, 25 Apr 2023 18:36:45 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> @andy-goryachev-oracle My highest priorities are #425 (Mac) and the Java code in this PR. I'll get it switched over to Windows as soon as possible so we have a complete implementation of the new key event pipeline to review. Third on the list is the Linux Robot code (#718) but the documentation of that API is, um, scattered so I don't expect the review to go all that quickly.
>
> Thank you for clarifications, @beldenfox .

@andy-goryachev-oracle My apologies, I really should have cleaned this PR up weeks ago when the bridgekeeper bot flagged it.

The portion of this PR that is platform-agnostic was also submitted in PR #1126. In that PR I incorporated all of the feedback you already provided (and thank you for that). I re-submitted all of this with a Windows front- and back-end because at the time Windows was the only platform with working Robot code so the changes could be tested (the manual app is included in #1126 as well as #425). I was also hoping that the review would go faster on Windows since no one seems to have much familiarity with the Linux API's except me and @tsayao (and the documentation is wretched).

I've already done a bit of cleanup over in #1126 that conflict with the changes here (I just renamed some routines). I've kept this PR around so the Linux-specific code can be reviewed but I should probably switch it over to Draft. And the Linux Robot code needs to be reviewed and integrated first to enable testing (#718).

-------------

PR Comment: https://git.openjdk.org/jfx/pull/694#issuecomment-1583664102