RFR: 8273743: KeyCharacterCombination for "+" does not work on US QWERTY keyboard layout [v5]

[Martin Fox]

On Fri, 9 Jun 2023 00:22:57 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:

>> Martin Fox has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Updating classpath for Eclipse users
>
> tests/manual/events/KeyCharacterCombinationTest.java line 45:
> 
>> 43: 
>> 44:     @Override
>> 45:     public void start(Stage stage) {
> 
> I started the test app but was unsure how to test it. Maybe add a header text that explains how a successful test should go.

There's now a better test app in tests/manual/events/KeyboardTest.java. With KeyCharacterCombinationTest the human tester has to press a bunch of keys. KeyboardTest.java uses a Robot to automate the process. The downside is that KeyboardTest.java relies on working Robot code so it can't really be used on Linux until #718 is integrated. I'll update the comments on this in the interim.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/694#discussion_r1224807391