RFR: 8302511: HitInfo.toString() throws IllegalArgumentException [v2]

[Karthik P K]

On Thu, 15 Jun 2023 18:38:14 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> A recent change in JDK-8304831 ensured that insertionIndex is always computed prior to HitInfo construction, making it possible to remove buggy logic in HitInfo.  This change also allows for removal of the 'text' field. 
>> 
>> There should be no impact since the constructor is package protected.
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   review comments

Thanks for updating the test and adding new test @andy-goryachev-oracle.
Please check the jcheck failure.
I have one minor comment added inline.

tests/system/src/test/java/test/robot/javafx/scene/TextSurrogatePairInsertionIndexTest.java line 100:

> 98:     public static void initFX() {
> 99:         long seed = new Random().nextLong();
> 100:         System.out.println("seed=" + seed);

Do we need this print statement?

-------------

Changes requested by kpk (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1154#pullrequestreview-1483001453
PR Review Comment: https://git.openjdk.org/jfx/pull/1154#discussion_r1231956600