RFR: 8310638: Filtering a TableView with a large number of items freezes the UI [v2]

[Andy Goryachev]

On Mon, 26 Jun 2023 17:11:26 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> This PR fix a performance issue introduced by the fix for JDK-8306447. In that PR, we changed the behavior in case the cellcount changes. In case the cellcount changes to a lower value than the original one, we have to make sure the current index is not higher than the new amount of cells as that would lead to unnecessary computations.
>> 
>> Fix for JDK-8310638
>
> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change access to package scope

Tested with the Monkey Tester
https://github.com/andy-goryachev-oracle/MonkeyTest

see no ill effects.

modules/javafx.controls/src/main/java/javafx/scene/control/skin/VirtualFlow.java line 861:

> 859:             double oldOffset = computeViewportOffset(getPosition(), oldCount);
> 860:             int cellCount = get();
> 861:             if (oldIndex > cellCount) oldIndex = cellCount;

minor: add { }'s ?

-------------

PR Review: https://git.openjdk.org/jfx/pull/1163#pullrequestreview-1499306492
PR Review Comment: https://git.openjdk.org/jfx/pull/1163#discussion_r1242691904