RFR: 8310638: Filtering a TableView with a large number of items freezes the UI [v2]

Kevin Rushforth kcr at openjdk.org
Mon Jun 26 22:01:13 UTC 2023


On Mon, 26 Jun 2023 17:11:26 GMT, Johan Vos <jvos at openjdk.org> wrote:

>> This PR fix a performance issue introduced by the fix for JDK-8306447. In that PR, we changed the behavior in case the cellcount changes. In case the cellcount changes to a lower value than the original one, we have to make sure the current index is not higher than the new amount of cells as that would lead to unnecessary computations.
>> 
>> Fix for JDK-8310638
>
> Johan Vos has updated the pull request incrementally with one additional commit since the last revision:
> 
>   change access to package scope

The change and explanation looks good to me. I confirm that the newly added test fails without the fix and passes with the fix.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/1163#pullrequestreview-1499558851


More information about the openjfx-dev mailing list