RFR: 8172849: Non-intuitive baseline alignment for labeled controls with graphics [v2]
Ajit Ghaisas
aghaisas at openjdk.org
Thu Mar 23 10:35:56 UTC 2023
On Fri, 17 Mar 2023 06:12:07 GMT, Karthik P K <kpk at openjdk.org> wrote:
>> Issue was observed because even when graphic height was less than text height of the Label, graphic height was considered while calculating the baseline offset. This was shifting the baseline offset and resulted in misalignment.
>>
>> Updated `computeBaselineOffset` to exclude graphic height from baseline offset calculation when graphic height is more than text height.
>>
>> Added unit test to validate the fix.
>
> Karthik P K has updated the pull request incrementally with one additional commit since the last revision:
>
> Update comment
Looks good to me!
-------------
Marked as reviewed by aghaisas (Reviewer).
PR Review: https://git.openjdk.org/jfx/pull/1059#pullrequestreview-1354291884
More information about the openjfx-dev
mailing list