RFR: JDK-8306490: Fix raw type warnings in graphics [v2]
John Hendrikx
jhendrikx at openjdk.org
Thu May 11 11:38:49 UTC 2023
On Wed, 10 May 2023 16:49:56 GMT, Nir Lisker <nlisker at openjdk.org> wrote:
> I started reviewing but there are too many files, which makes the GitHub interface unresponsive. Can you break it into 4 PRs of ~50 files chunks?
>
> Many of these are not trivial changes - finding the correct type requires understanding what's going on in the code.
I've removed about 2/3rds of the changes. There is a lot of relations between files so after a removal by package to slim down the PR I still had to fix like 50 problems manually again to make it an error free build. The results will be that not all files I touched in this split PR will have all fixes applied, so you may encounter files that are partially fixed.
Please focus on the warnings fixes, not on style issues that you happen to see on the same line; often the whole file will be using that style and fixing it one place just makes it even less consistent.
Also note: `ParsedValue` is an interface that has been parameterized that probably should not have been. The way it is used means that the parameters are more detrimental than beneficial. `ParsedValue`s are often layered, and are often arrays that are not homogenous (meaning they must be of type `Object`). It is unfortunately public API, and removing the parameters at this stage is probably going to be hard. I've done my best to specify the parameters when they are homegenous (like a `ParsedValue<?, Size>{]` where all parsed results are `Size`s), but far more often the contents are mixed types and so all you can say is `?`...
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1095#issuecomment-1543835089
More information about the openjfx-dev
mailing list