RFR: JDK-8306490: Fix raw type warnings in graphics [v2]

[John Hendrikx]

On Tue, 9 May 2023 22:42:19 GMT, Nir Lisker <nlisker at openjdk.org> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove 136 changed files
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/css/BitSet.java line 238:
> 
>> 236:         }
>> 237: 
>> 238:         BitSet<?> other = (BitSet<?>) c;
> 
> Shouldn't it be `<? extends T>`?

It makes no difference, it could be `BitSet<String>` or `BitSet<? super T>` or anything really, because the type `T` is never used as part of this method.  `BitSet<?>` is the shortest form in that case.

> modules/javafx.graphics/src/main/java/com/sun/javafx/css/ParsedValueImpl.java line 431:
> 
>> 429:                 pvi.writeBinary(os, stringStore);
>> 430:             } else {
>> 431:                 final ParsedValueImpl<?, ?> impl = new ParsedValueImpl<>((Object) pv.getValue(), (StyleConverter<Object, Object>) pv.getConverter());
> 
> I'm getting a warning on the cast to `(StyleConverter<Object, Object>)`.

It's an unchecked cast warning.

Since it's not a raw type warning, I've ignored these.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1095#discussion_r1191043446
PR Review Comment: https://git.openjdk.org/jfx/pull/1095#discussion_r1191045080