RFR: 8223373: Remove IntelliJ IDEA specific files from the source code repository [v6]
Ambarish Rapte
arapte at openjdk.org
Tue May 23 15:23:47 UTC 2023
On Sat, 15 Apr 2023 23:32:40 GMT, Thiago Milczarek Sayao <tsayao at openjdk.org> wrote:
>> This PR does:
>>
>> - Remove specific Idea files and let it be imported from gradle;
>> - Adds checkstyle (to use with checkstyle plugin - it will let you know style mistakes);
>> - Configures auto-format to sun style (with the changes mentioned in [Code Style Rules](https://wiki.openjdk.org/display/OpenJFX/Code+Style+Rules));
>> - Automatically sets Copyright notice (updates year too);
>
> Thiago Milczarek Sayao has updated the pull request incrementally with two additional commits since the last revision:
>
> - Update .gitignore
> - Remove unrelated gitignore
I am testing with IntelliJ IDEA 2023.1.2 (Community Edition).
Made some changes in a java file, added empty line with spaces, trailing spaces, added tabs at random places.
All the spaces on empty line, trailing spaces were correctly removed, tabs were replaced with spaces by the IDE with or **without** this change. Am I missing anything here?
Copyright year was not updated in the modified file. Are there any other steps to follow ?
Also, without this change, the gradle tries to build the project as soon as we open the project in IDE, but with this change it does not. which seems OK to me.
Also I do not use IDE to build jfx nor to execute the tests. If you do, can you please share me any specific steps.
-------------
PR Comment: https://git.openjdk.org/jfx/pull/1009#issuecomment-1559618499
More information about the openjfx-dev
mailing list