RFR: 8223373: Remove IntelliJ IDEA specific files from the source code repository [v6]

Thiago Milczarek Sayao tsayao at openjdk.org
Sat May 27 14:01:03 UTC 2023


On Tue, 23 May 2023 15:00:27 GMT, Ambarish Rapte <arapte at openjdk.org> wrote:

> I am testing with IntelliJ IDEA 2023.1.2 (Community Edition). Made some changes in a java file, added empty line with spaces, trailing spaces, added tabs at random places. All the spaces on empty line, trailing spaces were correctly removed, tabs were replaced with spaces by the IDE with or **without** this change. Am I missing anything here? Copyright year was not updated in the modified file. Are there any other steps to follow ? Also, without this change, the gradle tries to build the project as soon as we open the project in IDE, but with this change it does not. which seems OK to me.
> 
> Also I do not use IDE to build jfx nor to execute the tests. If you do, can you please share me any specific steps.

I configured it to follow Sun style with JavaFX exceptions (like allow longer line width) Converting tabs to space and removing trailing spaces are probably default.

About updating copyright year, maybe it's an Ultimate feature that might not be available in Community.

Tests are not working yet, because Idea is not able to correctly import from Gradle without changing it (I tried it but reverted to keep it unchanged for this PR).

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1009#issuecomment-1565431853


More information about the openjfx-dev mailing list