RFR: 8308644: [Linux] Simplify and fix small bugs on glass key related events [v2]
Thiago Milczarek Sayao
tsayao at openjdk.org
Tue May 23 22:57:38 UTC 2023
> While working on IME I noticed this code could be simplified, so I removed the `g_hash_table` usage for a simple struct ordered for binary search (I'm sure it's ordered because I did a simple app to generate it ordered).
>
> This also fixes:
>
> - UNKNOWN key codes being sent on KEY_PRESS;
> - Alt Gr is now working;
> - Replaced X calls with GDK calls for key locked check for as a small step towards supporting Wayland in the future
> - Added missing mappings (for F13 - F24 and dead keys) - Linux does not send dead keys as keypress but sends as key release, and they might be used on a robot test, so it's now covered.
Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
Revert modifier change + Remove F13 -> F24
-------------
Changes:
- all: https://git.openjdk.org/jfx/pull/1143/files
- new: https://git.openjdk.org/jfx/pull/1143/files/f1bf9f47..f7a9f6f2
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jfx&pr=1143&range=01
- incr: https://webrevs.openjdk.org/?repo=jfx&pr=1143&range=00-01
Stats: 15 lines in 1 file changed: 1 ins; 13 del; 1 mod
Patch: https://git.openjdk.org/jfx/pull/1143.diff
Fetch: git fetch https://git.openjdk.org/jfx.git pull/1143/head:pull/1143
PR: https://git.openjdk.org/jfx/pull/1143
More information about the openjfx-dev
mailing list