RFR: 8308644: [Linux] Simplify and fix small bugs on glass key related events [v4]

Wed May 24 13:27:10 UTC 2023

On Tue, 23 May 2023 15:42:18 GMT, Martin Fox <duke at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - Forgot test code
>>  - Back to hash
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_key.cpp line 225:
> 
>> 223:     { GDK_KEY_F22, com_sun_glass_events_KeyEvent_VK_F22 },
>> 224:     { GDK_KEY_F23, com_sun_glass_events_KeyEvent_VK_F23 },
>> 225:     { GDK_KEY_F24, com_sun_glass_events_KeyEvent_VK_F24 },
> 
> F13 on up used to be in the mapping tables on both Mac and Windows but were commented out long ago. This happened before everything was migrated to git and there's no bug number or comment in the code that explains why this happened. I would just leave them out.

Removed.

> modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 479:
> 
>> 477: 
>> 478:     // do not send undefined keys
>> 479:     if (glassKey > 0) {
> 
> I haven't run this code but this looks wrong. There are many keys which don't have key codes including most characters with accents or other diacritic marks (like ñ on a Spanish layout). These have always generated PRESSED and RELEASED events with undefined key codes.

It was wrong, fixed.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1143#discussion_r1204132482
PR Review Comment: https://git.openjdk.org/jfx/pull/1143#discussion_r1204131116