RFR: 8308644: [Linux] Simplify and fix small bugs on glass key related events [v2]

[Thiago Milczarek Sayao]

On Tue, 23 May 2023 17:05:13 GMT, Martin Fox <duke at openjdk.org> wrote:

>> Thiago Milczarek Sayao has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Revert modifier change + Remove F13 -> F24
>
> modules/javafx.graphics/src/main/native-glass/gtk/glass_key.cpp line 396:
> 
>> 394: 
>> 395:         case com_sun_glass_events_KeyEvent_VK_NUM_LOCK:
>> 396:             return (gdk_keymap_get_num_lock_state(keymap))
> 
> Have you tried testing this with a Wayland backend? I was doing some testing and it seemed that unless JavaFX opened a window we didn't connect with the Wayland server so we couldn't get accurate keyboard layout information. It wouldn't surprise me if this also prevented us from getting accurate keyboard state so the manual test for this code (which does not create a window) might fail. Beyond that I agree we should be migrating away from X11 calls if possible.

I have attached a `key_release.c` on the JBS bug, it works better on Wayland. On Xorg when you release the CAPS LOCK it will report as still ON until you press another key.

Compile with gcc -o key_release key_release.c `pkg-config --cflags --libs gtk+-3.0`

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1143#discussion_r1203165410