Integrated: 8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored

Kevin Rushforth kcr at openjdk.org
Wed Nov 1 16:09:17 UTC 2023


On Wed, 1 Nov 2023 15:16:54 GMT, Kevin Rushforth <kcr at openjdk.org> wrote:

> A recent change to Skara in processing of the .jcheck/conf file ([SKARA-2080](https://bugs.openjdk.org/browse/SKARA-2080)) introduced a bug in processing the `[checks "reviewers"]` section that causes the `/reviewers` command to be ignored in some cases. This is tracked by [SKARA-2088](https://bugs.openjdk.org/browse/SKARA-2088). The reason we tripped over this bug is that the `.jcheck/conf` file used by jfx (including various update release repos) uses an unrecognized key, "minimum", instead of the expected "reviewers" key to indicate the minimum number of reviewers. We should fix this to be consistent with what Skara expects given the intent of our `[checks "reviewers"]` section.

This pull request has now been integrated.

Changeset: 72c052ee
Author:    Kevin Rushforth <kcr at openjdk.org>
URL:       https://git.openjdk.org/jfx/commit/72c052ee2ad7b1f74c3c57078917c719d66a9c10
Stats:     1 line in 1 file changed: 0 ins; 0 del; 1 mod

8319231: Unrecognized "minimum" key in .jcheck/conf causes /reviewers command to be ignored

Reviewed-by: ehelin, angorya

-------------

PR: https://git.openjdk.org/jfx/pull/1275


More information about the openjfx-dev mailing list