RFR: 8320796: CssMetaData.combine() [v4]

[Michael Strauß]

On Tue, 28 Nov 2023 18:46:54 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

> > 1. I wouldn't frame this as introducing a new requirement, but merely clarifying the specification.
> 
> I'd rather leave this as is. If it is a requirement, then a) there should be a rationale and b) it has to be tested, at least in all of the core classes. This, frankly, is beyond the scope of this PR, I'd think.

But I've already explained the rationale: a subclass **cannot** hide its inherited JavaFX properties. This is the way the Java language works. Allowing this method to circumvent basic language semantics isn't sensible API design.

Furthermore, it is already tested by the very fact that this is the current de-facto standard (i.e. that there's no such thing as "hidden" properties). There are no tests, however, that explicitly test "hidden" JavaFX properties. This is not a feature, this is a specification bug.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1296#issuecomment-1830498070