RFR: 8320796: CssMetaData.combine() [v4]

[Andy Goryachev]

On Tue, 28 Nov 2023 00:51:36 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Provides a public utility method for use by the skins (core and custom) to simplify initialization of styleable properties.
>> 
>> 
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list with the size equal to the number
>> + * of items it holds (i.e. with no unnecessary overhead).
>> + *
>> + * @param list the css metadata items, usually from the parent, not nullable
>> + * @param items the additional items
>> + * @return the unmodifiable list containing all of the items
>> + *
>> + * @since 22
>> + */
>> + public static List<CssMetaData<? extends Styleable, ?>> combine(
>> + List<CssMetaData<? extends Styleable, ?>> list,
>> + CssMetaData<? extends Styleable, ?>... items)
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   combine

> 1. I wouldn't frame this as introducing a new requirement, but merely clarifying the specification.

I'd rather leave this as is.  If it is a requirement, then a) there should be a rationale and b) it has to be tested, at least in all of the core classes.  This, frankly, is beyond the scope of this PR, I'd think.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1296#issuecomment-1830475580