RFR: 8320796: CssMetaData.combine() [v4]

[Nir Lisker]

On Tue, 28 Nov 2023 00:51:36 GMT, Andy Goryachev <angorya at openjdk.org> wrote:

>> Provides a public utility method for use by the skins (core and custom) to simplify initialization of styleable properties.
>> 
>> 
>> + /**
>> + * Utility method which combines CssMetaData items in one unmodifiable list with the size equal to the number
>> + * of items it holds (i.e. with no unnecessary overhead).
>> + *
>> + * @param list the css metadata items, usually from the parent, not nullable
>> + * @param items the additional items
>> + * @return the unmodifiable list containing all of the items
>> + *
>> + * @since 22
>> + */
>> + public static List<CssMetaData<? extends Styleable, ?>> combine(
>> + List<CssMetaData<? extends Styleable, ?>> list,
>> + CssMetaData<? extends Styleable, ?>... items)
>
> Andy Goryachev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   combine

I don't see an explanation on why this is needed and what the use cases are (who is this intended for, how it's supposed to be used, and what's the current bad way of doing it). The JBS ticket doesn't mention anything either, and I haven't seen a discussion on the mailing list, which is required for new features.

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1296#issuecomment-1830513522